Disagreement about the system config file auto-detection

[Mavlarn]

Hi Juno,

I found that you add some code to detect the system.conf file modification. And if someone modified the system.conf file, it will detect that and reload the configuration. 

And you did the same for announcement.

What I think is, we provided the function for admin to modify the system config and announcement from the page. And if admin modified them, when we save the content, we can reload it just after saving.

Now you add this detection, it is only useful if administrator login to the server and modify the file.  But on the contrary, this detection will increase the burden of the server. Because this detection is implemented by a thread to check the file every 2 seconds.

I don't know whether you have some other reason to do that. If no, I think it is better to remove that.

Thanks.

[junoyoon]

The reason I made this is to reduce the real operation overhead.

As previous impl for annoucement.conf is only affected to only one server.

In cluster env, the changes made by one server is not reflected to the other server..

The operator should have always update this conf every server...

For our SSO system. it's not allowed to access the server with the ip. 

If we access it with ip, it will return cookies for wrong domain, and finally causes the cache inconsistency.

Only way we can do.. is to modify hosts file in local computer.

However I can not stand this overhead...

The better impl might be to use the replicated cache for this..

It will reduce the need of 2 sec checking.. I know this.

Just leave it right now... because current controller cpu usage is less than 10%.

So.. it's enough spaces to have such a burden..

If it's really necessary, let's do it in 3.2, please.

JunHo Yoon
Global Platform Development Lab / Senior Engineer

13th FL., Bundang First Tower, 266-1, Seohyeon-dong, Bundang-gu, Seongnam-si, Gyeonggi-do, 463-824, KOREA
Tel [phone]   Fax --   Mobile [phone]
Email  [hidden email]

-----Original Message-----
From: "Mavlarn [via ngrinder]"<[hidden email]>
To: "junoyoon"<[hidden email]>;
Cc:
Sent: 2012-12-13 (목) 15:49:40
Subject: Disagreement about the system config file auto-detection

Hi Juno,

I found that you add some code to detect the system.conf file modification. And if someone modified the system.conf file, it will detect that and reload the configuration. 

And you did the same for announcement.

What I think is, we provided the function for admin to modify the system config and announcement from the page. And if admin modified them, when we save the content, we can reload it just after saving.

Now you add this detection, it is only useful if administrator login to the server and modify the file.  But on the contrary, this detection will increase the burden of the server. Because this detection is implemented by a thread to check the file every 2 seconds.

I don't know whether you have some other reason to do that. If no, I think it is better to remove that.

Thanks.

---

If you reply to this email, your message will be added to the discussion below:

http://ngrinder.642.n7.nabble.com/Disagreement-about-the-system-config-file-auto-detection-tp84.html

To start a new topic under ngrinder_dev, email [hidden email]
To unsubscribe from ngrinder_dev, click here.
NAML